rymurr commented on a change in pull request #2881:
URL: https://github.com/apache/iceberg/pull/2881#discussion_r678976219
##########
File path: api/src/main/java/org/apache/iceberg/io/ClosingIterator.java
##########
@@ -25,33 +25,30 @@
public class ClosingIterator<T> implements Iterator<T> {
private final CloseableIterator<T> iterator;
- private boolean shouldClose = false;
public ClosingIterator(CloseableIterator<T> iterator) {
this.iterator = iterator;
-
}
@Override
public boolean hasNext() {
boolean hasNext = iterator.hasNext();
- this.shouldClose = !hasNext;
+ if (!hasNext) {
+ close();
+ }
return hasNext;
}
@Override
public T next() {
- T next = iterator.next();
+ return iterator.next();
+ }
- if (shouldClose) {
- // this will only be called once because iterator.next would throw
NoSuchElementException
- try {
- iterator.close();
- } catch (IOException e) {
- throw new UncheckedIOException(e);
- }
+ private void close() {
Review comment:
What is the behaviour if htis iterator is being used in parallel?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
