TGooch44 commented on a change in pull request #2761:
URL: https://github.com/apache/iceberg/pull/2761#discussion_r679072644
##########
File path: python/iceberg/api/expressions/inclusive_manifest_evaluator.py
##########
@@ -159,3 +159,7 @@ def in_(self, ref, lit):
def not_in(self, ref, lit):
return ROWS_MIGHT_MATCH
+
+ def starts_with(self, ref, lit):
+ # if it's all null then we can't match :)
+ return self.not_null(ref)
Review comment:
I don't have a strong opinion here but the convention in the java
library is that the leaf predicates always return either of those constants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
