chenjunjiedada commented on a change in pull request #2841: URL: https://github.com/apache/iceberg/pull/2841#discussion_r679775054
########## File path: api/src/main/java/org/apache/iceberg/actions/RewriteDeletes.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Set; +import org.apache.iceberg.DeleteFile; + +public interface RewriteDeletes extends SnapshotUpdate<RewriteDeletes, RewriteDeletes.Result> { + + /** + * rewrite the equality deletes. + * + * @return this for method chaining + */ + RewriteDeletes rewriteEqDeletes(); Review comment: `rewriteEqDeletes` and `rewritePosDeletes` is a top-level choice for users to choose which kind of delete he or she wants to rewrite. Here's an example: `actionsProvider().rewriteDeletes(table).rewriteEqDeletes().execute();`, users could clearly know what kind of deletes are handled. But you remind me that, we might also don't need these two as well, use one `strategy` API to select its implementation is enough. The strategy options are open and we could pass options from `options` interface from the specified strategy implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
