chenjunjiedada commented on a change in pull request #2364:
URL: https://github.com/apache/iceberg/pull/2364#discussion_r679863560
##########
File path: data/src/main/java/org/apache/iceberg/data/DeleteFilter.java
##########
@@ -96,6 +98,29 @@ public Schema requiredSchema() {
return requiredSchema;
}
+ protected int deleteMarkerIndex() {
+ if (deleteMarkerIndex != null) {
+ return deleteMarkerIndex;
+ }
+
+ int index = 0;
+ for (Types.NestedField field : requiredSchema().columns()) {
+ if (field.fieldId() != MetadataColumns.IS_DELETED.fieldId()) {
+ index = index + 1;
+ } else {
+ break;
+ }
+ }
+
+ deleteMarkerIndex = index;
+
+ return deleteMarkerIndex;
+ }
+
+ protected abstract Consumer<T> deleteMarker();
Review comment:
I can try to make this better abstraction in the following PR, this PR
contains too many changes now. I think we will have some following-up minor
changes and optimizations. Does that sound ok to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
