stevenzwu opened a new pull request #2905: URL: https://github.com/apache/iceberg/pull/2905
With this composition mode, `DataIterator` deals with `CombinedScanTask` and `IteratorReader` deals with individual `FileScanTask`. `DataIterator` use composition to reference `IteratorReader` Here are the motivations behind this change 1) address @openinx 's [review comment](https://github.com/apache/iceberg/pull/2105#discussion_r568303231) 2) make it easier to extend. E.g., internally we would like to add another converter from RowData to some other type Foo. We can't define some `FooDataIterator extends RowDataIterator` as the generic type is already fixed to `RowData`. With this new composition model, we can define a `FooIteratorReader implements IteratorReader` and uses `RowDataIteratorReader` by composition in the `FooIteratorReader`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
