Reo-LEI commented on a change in pull request #2898:
URL: https://github.com/apache/iceberg/pull/2898#discussion_r681116142
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -313,13 +320,21 @@ public Builder uidPrefix(String newPrefix) {
switch (writeMode) {
case NONE:
- return input;
+ if (!equalityFieldIds.isEmpty()) {
+ return input.keyBy(new EqualityFieldKeySelector(equalityFieldIds,
table.schema(), flinkRowType));
+ } else {
+ return input;
+ }
case HASH:
- if (partitionSpec.isUnpartitioned()) {
- return input;
- } else {
+ if (!partitionSpec.isUnpartitioned() && !equalityFieldIds.isEmpty())
{
+ return input.keyBy(new HybridKeySelector(partitionSpec,
equalityFieldIds, iSchema, flinkRowType));
+ } else if (!partitionSpec.isUnpartitioned() &&
equalityFieldIds.isEmpty()) {
return input.keyBy(new PartitionKeySelector(partitionSpec,
iSchema, flinkRowType));
+ } else if (partitionSpec.isUnpartitioned() &&
!equalityFieldIds.isEmpty()) {
+ return input.keyBy(new EqualityFieldKeySelector(equalityFieldIds,
table.schema(), flinkRowType));
+ } else {
+ return input;
Review comment:
That is make sense, I will add an utility method to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
