rdblue commented on a change in pull request #2877:
URL: https://github.com/apache/iceberg/pull/2877#discussion_r681331863
##########
File path: core/src/main/java/org/apache/iceberg/StaticDataTask.java
##########
@@ -30,18 +30,26 @@
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.util.StructProjection;
class StaticDataTask implements DataTask {
- static <T> DataTask of(InputFile metadata, Iterable<T> values, Function<T,
Row> transform) {
+ static <T> DataTask of(InputFile metadata, Iterable<T> values, Function<T,
Row> transform,
+ Schema original, Schema projected) {
Review comment:
Nit: I'm not sure if it's just me, but I'd normally place lambda
function arguments at the end of the list. Since this is internal, we can move
these just after `InputFile`.
Also, is original always the table schema? If so, maybe we should use
`tableSchema` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
