RussellSpitzer commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r681839251



##########
File path: core/src/main/java/org/apache/iceberg/FindFiles.java
##########
@@ -103,7 +103,7 @@ public Builder asOfTime(long timestampMillis) {
       // case, there is no valid snapshot to read.
       Preconditions.checkArgument(lastSnapshotId != null,
           "Cannot find a snapshot older than %s",
-          
DATE_FORMAT.format(LocalDateTime.ofInstant(Instant.ofEpochMilli(timestampMillis),
 ZoneId.systemDefault())));

Review comment:
       Another slight change in behavior here ... I would probably save these 
for another PR unless we really need it here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to