rdblue commented on a change in pull request #2887:
URL: https://github.com/apache/iceberg/pull/2887#discussion_r681881767
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -764,7 +778,7 @@ public TableMetadata buildReplacement(Schema updatedSchema,
PartitionSpec update
schemasBuilder.add(new Schema(freshSchemaId, freshSchema.columns(),
freshSchema.identifierFieldIds()));
}
- return new TableMetadata(null, formatVersion, uuid, newLocation,
+ return new TableMetadata(null, newFormatVersion, uuid, newLocation,
Review comment:
I think that this also needs to call `upgradeToFormatVersion` to ensure
that there is no version rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
