kbendick commented on a change in pull request #2921:
URL: https://github.com/apache/iceberg/pull/2921#discussion_r683760308
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -42,7 +44,8 @@
private static final ProcedureParameter[] PARAMETERS = new
ProcedureParameter[] {
ProcedureParameter.required("table", DataTypes.StringType),
ProcedureParameter.optional("older_than", DataTypes.TimestampType),
- ProcedureParameter.optional("retain_last", DataTypes.IntegerType)
+ ProcedureParameter.optional("retain_last", DataTypes.IntegerType),
+ ProcedureParameter.optional("num_parallelism", DataTypes.IntegerType)
Review comment:
Nit (non-blocking): This parameter name is a bit confusing for me.
Perhaps simply `num_threads` would do? It is indeed difficult to think of a
name that does not evoke the normal spark task parallelism. Maybe even just
`parallelism` would do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
