aokolnychyi commented on a change in pull request #2945: URL: https://github.com/apache/iceberg/pull/2945#discussion_r684542082
########## File path: core/src/main/java/org/apache/iceberg/io/DeltaTaskWriter.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.IOException; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.util.CharSequenceSet; + +public interface DeltaTaskWriter<T> extends V2TaskWriter<T> { + + // equality delete + void delete(T row, PartitionSpec spec, StructLike partition) throws IOException; + + // position delete with persisting row + void delete(CharSequence path, long pos, T row, PartitionSpec spec, StructLike partition) throws IOException; + + // position delete without persisting row + default void delete(CharSequence path, long pos, PartitionSpec spec, StructLike partition) throws IOException { Review comment: One potential optimization is to wrap query engine specific String representations as `CharSequence`. For example, we do spend some noticeable amount of time converting `UTF8String` into Java `String` whenever we retrieve the path from `InternalRow`. Should be investigated separately, though. Thoughts, @rdblue @RussellSpitzer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
