rdblue commented on a change in pull request #2952:
URL: https://github.com/apache/iceberg/pull/2952#discussion_r685351745
##########
File path: api/src/main/java/org/apache/iceberg/types/PruneColumns.java
##########
@@ -27,10 +27,23 @@
class PruneColumns extends TypeUtil.SchemaVisitor<Type> {
private final Set<Integer> selected;
+ private final boolean onlySelected;
+
+ /**
+ * Visits a schema and returns only those element's whose id's have been
passed as selected
+ * @param selected ids of elements to return
+ * @param onlySelected whether to return only elements which have been
selected, no sub elements
Review comment:
This wording seems a bit unclear to me since the purpose of this class
is to return only the selected fields. I think that it misses the context that
this affects the fields that are selected when a struct itself is selected.
What about renaming this to `selectFullStructs` or `selectEmptyStructs`?
Then the javadoc would be "whether explicitly selected structs should contain
all fields or no fields".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
