rdblue commented on a change in pull request #2953:
URL: https://github.com/apache/iceberg/pull/2953#discussion_r685378321
##########
File path: api/src/main/java/org/apache/iceberg/types/GetProjectedIds.java
##########
@@ -39,9 +39,7 @@
@Override
public Set<Integer> field(Types.NestedField field, Set<Integer> fieldResult)
{
- if (fieldResult == null) {
- fieldIds.add(field.fieldId());
- }
+ fieldIds.add(field.fieldId());
Review comment:
This is related to [my comment on the other
PR](https://github.com/apache/iceberg/pull/2952/files#r685370873). I don't
think that we should return inner IDs other than struct IDs or else it isn't
clear how lists and maps should be handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
