jun-he commented on a change in pull request #2956:
URL: https://github.com/apache/iceberg/pull/2956#discussion_r685689301
##########
File path: core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
##########
@@ -69,7 +69,7 @@
this.schema = spec.schema();
this.nameToField = indexSpecByName(spec);
this.transformToField = indexSpecByTransform(spec);
- this.lastAssignedPartitionId = base.lastAssignedPartitionId();
+ this.lastAssignedPartitionId = formatVersion == 1 ?
spec.lastAssignedFieldId() : base.lastAssignedPartitionId();
Review comment:
IIRC, there are multiple places handling it for v1, e.g.
https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L345-L350
If we use an iceberg library version with `BaseUpdatePartitionSpec` support,
will the base's lastAssignedPartitionId always be set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
