kbendick commented on a change in pull request #2950:
URL: https://github.com/apache/iceberg/pull/2950#discussion_r685721758
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -251,12 +251,12 @@ public void createNamespace(Namespace namespace,
Map<String, String> meta) {
namespace);
} catch (TException e) {
- throw new RuntimeException("Failed to create namespace " + namespace + "
in Hive MataStore", e);
+ throw new RuntimeException("Failed to create namespace " + namespace + "
in Hive MetaStore", e);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throw new RuntimeException(
- "Interrupted in call to createDatabase(name) " + namespace + " in
Hive MataStore", e);
+ "Interrupted in call to createDatabase(name) " + namespace + " in
Hive MetaStore", e);
Review comment:
If we go with `Metastore` and not `MetaStore` (which the former is
correct according to a number of Hive and Cloudera docs), this also needs to be
updated - plus several other locations :)
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -251,12 +251,12 @@ public void createNamespace(Namespace namespace,
Map<String, String> meta) {
namespace);
} catch (TException e) {
- throw new RuntimeException("Failed to create namespace " + namespace + "
in Hive MataStore", e);
+ throw new RuntimeException("Failed to create namespace " + namespace + "
in Hive MetaStore", e);
Review comment:
I’ve also always used `Metastore`.
Looking at this Hive design doc, it’s also `Metastore` with no capital S. I
think this makes the most sense as it’s not really two words imo (and several
Hive docs confirm it as being one word):
https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=27362072#Design-Metastore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
