kbendick edited a comment on pull request #2948:
URL: https://github.com/apache/iceberg/pull/2948#issuecomment-895824959


   > @rdblue yeah it should have been breaking since the commit #2721, but I 
assumed the integration tests were run by Kyle and did not verify it, and we 
never merged that change to our internal repo to test, so didn't find out the 
issue until now.
   > 
   > I think we have been talking about contributing an AWS account to run the 
integration tests as a part of the CI for any change related to the AWS module. 
It is currently application in progress, it should be the best way to avoid 
this kind of issue in the future.
   
   Thanks for this fix. I also (mistakenly) assumed that these tests were run 
during CI.
   
   It would be great if there were a way to run the integration tests on a 
semi-regular basis, or to add this to CI (even using dynamo-local and friends 
if need be to do it during CI - though ideally with real infrastructure would 
be preferable as I know at least dynamo-local isn't quite the same as DynamoDB 
from past experience). Or, do we have documentation for running these specific 
tests? I regularly run some test suites against AWS (in addition to other 
infrastructure) for things like releases, but it's just my own ad-hoc set up 
for things like ensuring table creation works, etc.
   
   FWIW, I just pulled master and I still get NPE when running `./gradlew 
:iceberg-aws:integrationTest`. How am I supposed to be running these? When I 
run `./gradlew clean build`, everything passes. But running `./gradlew 
:iceberg-aws:integrationTest` gives me several failures.
   
   ```
   > Task :iceberg-aws:integrationTest
   
   org.apache.iceberg.aws.glue.GlueCatalogNamespaceTest > classMethod FAILED
       java.lang.ExceptionInInitializerError
           Caused by: software.amazon.awssdk.core.exception.SdkClientException
   
   org.apache.iceberg.aws.glue.GlueCatalogNamespaceTest > classMethod FAILED
       java.lang.NoClassDefFoundError
   
   org.apache.iceberg.aws.glue.GlueCatalogCommitFailureTest > classMethod FAILED
       java.lang.NoClassDefFoundError
   
   ..... (more NoClassDefFoundError).
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to