kbendick commented on a change in pull request #2938:
URL: https://github.com/apache/iceberg/pull/2938#discussion_r687318854
##########
File path: dev/source-release.sh
##########
@@ -20,72 +20,137 @@
set -e
-if [ -z "$1" ]; then
- echo "Usage: $0 <version-num> <rc-num>"
- exit
-fi
-
-if [ -z "$2" ]; then
- echo "Usage: $0 <version-num> <rc-num>"
- exit
+usage () {
+ echo "usage: $0 [-k <key_id>] [-r <git_remote>] <version_num> <rc_num>"
+ echo " -k Specify signing key. Defaults to \"GPG default key\""
+ echo " -r Specify Git remote name. Defaults to \"origin\""
+ echo " -d Turn on DEBUG output"
+ exit 1
+}
+
+# Default repository remote name
+remote="origin"
+
+while getopts "k:r:d" opt; do
+ case "${opt}" in
+ k)
Review comment:
Oh that's news to me. Looking into it further, I was thinking of
`getopt`. It's better to stick with the default installation for most systems
though 👍.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
