rdblue commented on pull request #2848: URL: https://github.com/apache/iceberg/pull/2848#issuecomment-899702801
I think it would be better to add a feature to Iceberg rather than to expose classes. As is, this PR would make it possible to extend these in other unsupported ways and we don't want to create issues from having these as public classes or break you later because we consider them private but they are accessible. It's reasonable to add some ability to mark a table for a use case, like incremental appends or CDC, and to disable some operations for that use case. I would support that more than just opening up classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
