aokolnychyi commented on a change in pull request #2985:
URL: https://github.com/apache/iceberg/pull/2985#discussion_r689948261
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -117,11 +120,10 @@ public ThisT set(String property, String value) {
return self();
}
- protected PartitionSpec writeSpec() {
- Preconditions.checkState(spec != null,
- "Cannot determine partition spec: no data or delete files have been
added");
+ protected PartitionSpec dataSpec() {
Review comment:
Renaming this does require touching more places but I think keeping it
`writeSpec` will be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
