cwsteinbach commented on a change in pull request #2842:
URL: https://github.com/apache/iceberg/pull/2842#discussion_r690746728
##########
File path: site/docs/index.md
##########
@@ -20,8 +20,7 @@
# 
-**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg
adds tables to Trino and Spark that use a high-performance format that works
just like a SQL table.
-
+**Apache Iceberg is an open table format for huge analytic datasets.** Iceberg
adds tables to compute engines including Spark, Trino, PrestoDB, Flink and Hive
using a high-performance format that works just like a SQL table.
Review comment:
s/high-performance format/high-performance table format/
##########
File path: site/docs/trino-prestodb.md
##########
@@ -17,4 +17,11 @@
# Trino (formerly Presto SQL)
-The Iceberg connector is available with Trino. It is feature complete and
usage details can be found in the
[documentation](https://trino.io/docs/current/connector/iceberg.html)
+The Iceberg connector is available with PrestoSQL, which is rebranded as Trino
since January 2021.
Review comment:
The title already states that Trino used to be called Presto SQL,
stating it again in the paragraph seems redundant. Please consider replacing
this with: "The documentation for Iceberg's Trino connector has moved to the
Trino website. Please consult the [Iceberg
section](https://trino.io/docs/current/connector/iceberg.html) of the Trino
docs for more information."
##########
File path: site/docs/getting-started.md
##########
@@ -17,10 +17,14 @@
# Getting Started
-## Using Iceberg in Spark 3
-
The latest version of Iceberg is [{{ versions.iceberg }}](./releases.md).
+Spark is currently the most feature-rich compute engine for Iceberg
operations.
Review comment:
Please consider rewording: "We recommend using Spark to learn Iceberg
concepts and features since it is currently the most feature-rich compute
engine for Iceberg operations. However, if you prefer to start with a different
engine, we ask that you consult the documentation for directions on using
Iceberg with other compute engines. This documentation is located under the
**Engines** tab."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
