nastra commented on a change in pull request #2826: URL: https://github.com/apache/iceberg/pull/2826#discussion_r691002090
########## File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java ########## @@ -115,7 +115,7 @@ public String catalogName() { /** * The table properties string needed for the CREATE TABLE ... commands, * like "TBLPROPERTIES('iceberg.catalog'='mycatalog') - * @return + * @return The tables properties string, such as "TBLPROPERTIES('iceberg.catalog'='mycatalog') Review comment: ah this is just a blind copy/paste from the javadoc description a few lines above without actually me checking whether it had missing pieces..will update -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org