kbendick opened a new pull request #3004: URL: https://github.com/apache/iceberg/pull/3004
Presently, if somebody pushes to an open PR, the previous workflow run still goes to completion. This PR adds a cancel duplicate workflow run actions that will cancel them. I have tested this in my fork and confirmed thet it works. Because GitHub Actions work differently in forks than in the upstream repo, it's probably best we merge this and then work out any potential nuances in behavior. I have confirmed that it works in my fork though (of course if anybody catches anything in review, that's obviously better). I have not seen any, but major things I'd watch out for after merging this are: - Ensuring that we don't generate too many cancel workflow runs (that aren't needed) - this can be tuned by the events etc. This workflow is inexpensive compared to the actual CI so this isn't a large concern if it does happen for a bit. - Double check we're cancelling duplicate workflows (e.g. after push) when a new workflow is pushed. I've checked this in my fork, but forks behave differently than the upstream repo for GH Actions Things that I would grab in a v2: - Cancel workflows for PRs that have been merged (if still running) - especially useful for forks where we don't control the behavior of people's merging. Even if there are some minor kinks, the added availability of CI runners will greatly outweigh a small period of time with possibly extra workflow runs as Java CI takes >30 minutes and occupies ~4 task runners. This workflow takes ~30 seconds or so. I chose this action as it's used in Spark. This closes issue https://github.com/apache/iceberg/issues/3002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
