kbendick commented on a change in pull request #2998:
URL: https://github.com/apache/iceberg/pull/2998#discussion_r693265789



##########
File path: site/README.md
##########
@@ -49,10 +49,14 @@ To see changes in Javadoc, run:
 
 ### Publishing
 
-After site changes are committed, you can publish the site with this command:
+After site changes are committed, you can publish the site with this series of 
commands:
 
 ```
-mkdocs gh-deploy
+rm -r site
+mkdir site
+cp ../.asf.yaml site/

Review comment:
       If we're in the `$projectRoot/site` directory, should it be `rm -r docs 
&& mkdir docs`?
   
   My site directory looks as follows.
   
   ```
   $ ls -la site
   total 24
   drwxr-xr-x   6 kbendickson  staff   192B Aug 19 16:08 .
   drwxr-xr-x  59 kbendickson  staff   1.8K Aug 19 16:08 ..
   -rw-r--r--   1 kbendickson  staff   1.6K Aug 19 16:08 README.md
   drwxr-xr-x  43 kbendickson  staff   1.3K Aug 20 00:48 docs
   -rw-r--r--   1 kbendickson  staff   3.5K Aug 19 16:08 mkdocs.yml
   -rw-r--r--   1 kbendickson  staff   872B Aug 19 16:08 requirements.txt
   ```
   
   If I enter the site directory, and `rm -r site`, I get an exception.
   
   ```
   $ cd site
   $ rm -r site
   rm: site: No such file or directory
   ```
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to