kbendick commented on a change in pull request #3004: URL: https://github.com/apache/iceberg/pull/3004#discussion_r693565508
########## File path: .github/workflows/cancel-dupliate-workflow-runs.yml ########## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: "Cancel Duplicates" +on: + workflow_run: + workflows: + - 'Java CI' + - 'Python CI' + types: ['requested'] + +jobs: + cancel-duplicate-workflow-runs: + name: "Cancel duplicate workflow runs" + runs-on: ubuntu-latest + steps: + - uses: potiuk/cancel-workflow-runs@4723494a065d162f8e9efd071b98e0126e00f866 # @master + name: "Cancel duplicate workflow runs" + with: + cancelMode: allDuplicates + token: ${{ secrets.GITHUB_TOKEN }} Review comment: I believe the token is needed so that this workflow can cancel other workflows. It is mentioned as mandatory in the docs for the workflow. It seems to be required by a lot of workflows,[ including the labeler workflow](https://github.com/apache/iceberg/blob/master/.github/workflows/labeler.yml#L27-L29). According to the docs, it's also technically accessible on the `github` context even if not explicitly passed. Of note, [according to the docs](https://docs.github.com/en/actions/reference/authentication-in-a-workflow#about-the-github_token-secret), Github **creates a token when the action is started and that token is only valid for the lifetime of the action's run.** ``` Before each job begins, GitHub fetches an installation access token for the job. The token expires when the job is finished. ``` Here's a matrix of the [default permissions based on what's taking place](https://docs.github.com/en/actions/reference/authentication-in-a-workflow#permissions-for-the-github_token) (for us, this would probably need the `actions` permission). Complete [docs on permissions](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#permissions) are located here.  There's more scopes (like `issues`, etc) in the above linked table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
