kbendick edited a comment on pull request #3000: URL: https://github.com/apache/iceberg/pull/3000#issuecomment-903349461
Can this be done using a `try-with-resources` block instead? The reason I mention `try-with-resources` is that we had to allow adding shutdown hooks, which as you've pointed out, can potentially cause memory leaks. While you've taken the time to work around this, others might not. If it cannot be done with `try-with-resources`, can you let us know why not? Unfortunately I don't think I can get your github workflow to run as I don't believe I have that permission. Sorry! But I do think using `try-with-resources` would be all around better if possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
