Reo-LEI commented on a change in pull request #2863:
URL: https://github.com/apache/iceberg/pull/2863#discussion_r695846000
##########
File path: flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java
##########
@@ -63,6 +72,7 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
.tableLoader(tableLoader)
.tableSchema(tableSchema)
.equalityFieldColumns(equalityColumns)
+ .upsert(PropertyUtil.propertyAsBoolean(tableProperties,
UPSERT_MODE_ENABLED, UPSERT_MODE_ENABLED_DEFAULT))
Review comment:
Sounds good to me! I will extract this prop in `build()` and add a
validation for `overwrite` when `upsert` is enable. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
