kbendick opened a new issue #3045: URL: https://github.com/apache/iceberg/issues/3045
Looking through the current code in master for `Locale.*`, I found instances where we use `Locale.ROOT` and isntances where we use `Locale.English`. Unless there's a pressing need to use one or the other depending on the situation, we should probably stick to just one consistently to avoid possible confusion or errors. I could see non-English characters coming up in partition names in paths, for example. But off the top of my head, I can't think of a reason that Locale.ENGLISH would be needed and Locale.ROOT wouldn't suffice. Locale.ENGLISH is the most common one, by far. Count of instances of each - Locale.English - 48 - Locale.ROOT - 25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
