rdblue commented on a change in pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#discussion_r698060978
##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -77,6 +79,14 @@ public static MetricsConfig getDefault() {
}
public static MetricsConfig fromProperties(Map<String, String> props) {
+ return from(props, null);
+ }
Review comment:
Should we deprecate `fromProperties` or is there still a reasonable use
for it? Looks like we're moving over all of our internal calls to `forTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
