rdblue commented on a change in pull request #3048:
URL: https://github.com/apache/iceberg/pull/3048#discussion_r698061514
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/IcebergToGlueConverter.java
##########
@@ -132,4 +138,61 @@ static void validateTableIdentifier(TableIdentifier
tableIdentifier) {
validateNamespace(tableIdentifier.namespace());
validateTableName(tableIdentifier.name());
}
+
+ static List<Column> toColumns(Schema schema) {
Review comment:
Normally, we'd put conversion methods like this in a class called
`GlueSchemaUtil` instead of this converter class that is meant to be internal.
It would not be unreasonable to open up these methods later and if we do we
want some consistency in the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
