kbendick commented on a change in pull request #3047:
URL: https://github.com/apache/iceberg/pull/3047#discussion_r698061022
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -100,14 +97,14 @@ public void initialize(String name, Map<String, String>
properties) {
initializeFileIO(properties));
}
- private FileIO initializeFileIO(Map<String, String> properties) {
+ FileIO initializeFileIO(Map<String, String> properties) {
Review comment:
Non-blocking: Should we mark this as `protected`?
##########
File path:
aws/src/main/java/org/apache/iceberg/aws/glue/HadoopConfigurableGlueCatalog.java
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg.aws.glue;
+
+import java.util.Map;
+import org.apache.hadoop.conf.Configurable;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.iceberg.CatalogProperties;
+import org.apache.iceberg.CatalogUtil;
+import org.apache.iceberg.aws.s3.S3FileIO;
+import org.apache.iceberg.io.FileIO;
+
+/**
+ * Glue catalog that also accepts Hadoop configuration,
+ * for users that would like to use GlueCatalog with HadoopFileIO or
+ * other dynamic FileIO implementation that leverages Hadoop configuration.
+ */
Review comment:
Non-blocking: Should we add a note that users might want to use this
with Spark for example?
We can update the docs in a later PR though. For now this is more than
sufficient to unblock people who want to test in environments where they don't
have much control over the pre-configuration of the hadoop environment (and
where it's not technically needed).
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java
##########
@@ -69,12 +67,11 @@
import software.amazon.awssdk.services.glue.model.TableInput;
import software.amazon.awssdk.services.glue.model.UpdateDatabaseRequest;
-public class GlueCatalog extends BaseMetastoreCatalog implements Closeable,
SupportsNamespaces, Configurable {
+public class GlueCatalog extends BaseMetastoreCatalog implements Closeable,
SupportsNamespaces {
Review comment:
Nit - Can you add a short doc comment that mentions the
`HadoopConfigurableGlueCatalog`? E.g., I imagine that Spark users would want to
possibly use the `HadoopConfigurableGlueCatalog` in many cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
