kbendick commented on a change in pull request #3049:
URL: https://github.com/apache/iceberg/pull/3049#discussion_r698066955
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -411,11 +411,11 @@ public void testAddPreviousMetadataRemoveMultiple() {
long previousSnapshotId = System.currentTimeMillis() - new
Random(1234).nextInt(3600);
Snapshot previousSnapshot = new BaseSnapshot(
ops.io(), previousSnapshotId, null, previousSnapshotId, null, null,
null, ImmutableList.of(
- new GenericManifestFile(localInput("file:/tmp/manfiest.1.avro"),
SPEC_5.specId())));
+ new GenericManifestFile(localInput("file:/tmp/manfiest.1.avro"),
SPEC_5.specId())), null);
long currentSnapshotId = System.currentTimeMillis();
Snapshot currentSnapshot = new BaseSnapshot(
ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId,
null, null, null, ImmutableList.of(
- new GenericManifestFile(localInput("file:/tmp/manfiest.2.avro"),
SPEC_5.specId())));
+ new GenericManifestFile(localInput("file:/tmp/manfiest.2.avro"),
SPEC_5.specId())), null);
Review comment:
Nit: Is it possible to avoid having to pass all of these `null`s in?
EDIT: My bad - I was reading it as though the `null` was going to
`GenericManifestFile`. While I still don't love how large the `BaseSnapshot`
constructor has gotten, that seems outside of the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
