openinx commented on a change in pull request #2945: URL: https://github.com/apache/iceberg/pull/2945#discussion_r700155639
########## File path: core/src/main/java/org/apache/iceberg/io/MixedDeltaWriter.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.io; + +import java.io.IOException; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.deletes.PositionDelete; + +public class MixedDeltaWriter<T> extends BaseDeltaWriter<T> { Review comment: What's the specific case that `MixedDeltaWriter` will be used for ? If it's the batch UPDATE/DELETE case, then we should don't produce the equality-deletes , then I think we could just remain the `delete(T row, PartitionSpec spec, StructLike partition)` as Unsupported, we don't even wanna to initialize the equalityDeleteWriter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
