rdblue commented on a change in pull request #2847: URL: https://github.com/apache/iceberg/pull/2847#discussion_r701237163
########## File path: dell/src/main/java/org/apache/iceberg/dell/ObjectKey.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.dell; + +import java.util.Objects; + +/** + * a immutable record class of object key + */ +public class ObjectKey { + /** + * bucket + */ + private final String bucket; + + /** + * key + */ + private final String key; + + public ObjectKey(String bucket, String key) { Review comment: Something is not right here. The class is called `ObjectKey`, but it is created by passing a `String` called `key`. Is the string the key, or is it part of the key? Maybe this should be similar to S3, where the bucket/string combination is called a URI, `S3URI`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
