rdblue commented on a change in pull request #2952:
URL: https://github.com/apache/iceberg/pull/2952#discussion_r701365052
##########
File path: api/src/main/java/org/apache/iceberg/types/PruneColumns.java
##########
@@ -89,31 +111,39 @@ public Type field(Types.NestedField field, Type
fieldResult) {
@Override
public Type list(Types.ListType list, Type elementResult) {
if (selected.contains(list.elementId())) {
- return list;
- } else if (elementResult != null) {
- if (list.elementType() == elementResult) {
+ if (selectFullTypes) {
return list;
- } else if (list.isElementOptional()) {
- return Types.ListType.ofOptional(list.elementId(), elementResult);
+ } else if (list.elementType().isStructType()) {
+ StructType projectedStruct = projectSelectedStruct(elementResult);
+ return projectList(list, projectedStruct);
} else {
- return Types.ListType.ofRequired(list.elementId(), elementResult);
+ Preconditions.checkArgument(list.elementType().isPrimitiveType(),
+ "Cannot explicitly project List or Map types, Field %s of type %s
was selected",
Review comment:
Not really a "field" so much as a "list element"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
