stevenzwu commented on a change in pull request #3001:
URL: https://github.com/apache/iceberg/pull/3001#discussion_r701555537



##########
File path: build.gradle
##########
@@ -320,6 +320,8 @@ project(':iceberg-flink') {
     compile project(':iceberg-parquet')
     compile project(':iceberg-hive-metastore')
 
+    // for dropwizard histogram metrics implementation
+    compileOnly "org.apache.flink:flink-metrics-dropwizard"

Review comment:
       included the dropwizard jar in the iceberg-flink-runtime.jar. also 
removed the unnecessary exclude for flink in the iceberg-flink-runtime in 
build.gradle, as all flink deps are marked as `compileOnly`. Verified that we 
don't need the exclude with a locally built iceberg-flink-runtime.jar




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to