aokolnychyi commented on a change in pull request #3071:
URL: https://github.com/apache/iceberg/pull/3071#discussion_r702195345
##########
File path: core/src/main/java/org/apache/iceberg/BaseRowDelta.java
##########
@@ -91,7 +91,8 @@ public RowDelta validateNoConflictingAppends(Expression
newConflictDetectionFilt
protected void validate(TableMetadata base) {
if (base.currentSnapshot() != null) {
if (!referencedDataFiles.isEmpty()) {
- validateDataFilesExist(base, startingSnapshotId, referencedDataFiles,
!validateDeletes);
+ validateDataFilesExist(
+ base, startingSnapshotId, referencedDataFiles, !validateDeletes,
conflictDetectionFilter);
Review comment:
This does make the assumption that the conflict detection filter and
referenced data files are related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
