wang-x-xia commented on a change in pull request #2847: URL: https://github.com/apache/iceberg/pull/2847#discussion_r702440531
########## File path: dell/src/main/java/org/apache/iceberg/dell/ObjectKey.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.dell; + +import java.util.Objects; + +/** + * a immutable record class of object key + */ +public class ObjectKey { + /** + * bucket + */ + private final String bucket; + + /** + * key + */ + private final String key; + + public ObjectKey(String bucket, String key) { Review comment: In object storage, the object key contains both a bucket name and a key. And in my design, the user can provide different delimiters for object storage. For example, the user can create an object which bucket is _a_ and key is _folder2021-folder09-obj1_ with delimiter _-_. It's hard to format it as a string, so I move this to the `ObjectKeys` interface. And I need some time to check whether using `emc://bucket/key` as a general string. ########## File path: dell/src/main/java/org/apache/iceberg/dell/ObjectKey.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg.dell; + +import java.util.Objects; + +/** + * a immutable record class of object key + */ +public class ObjectKey { + /** + * bucket + */ + private final String bucket; + + /** + * key + */ + private final String key; + + public ObjectKey(String bucket, String key) { + if (bucket == null || key == null) { + throw new IllegalArgumentException(String.format("bucket %s and key %s must be not null", bucket, key)); + } + this.bucket = bucket; + this.key = key; + } + + public String getBucket() { + return bucket; + } + + public String getKey() { + return key; + } + + @Override + public String toString() { Review comment: See above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
