rdblue commented on a change in pull request #2829:
URL: https://github.com/apache/iceberg/pull/2829#discussion_r705741508



##########
File path: 
spark3/src/main/java/org/apache/iceberg/spark/actions/BaseRewriteDataFilesSpark3Action.java
##########
@@ -35,6 +36,11 @@ protected BinPackStrategy binPackStrategy() {
     return new Spark3BinPackStrategy(table(), spark());
   }
 
+  @Override
+  protected SortStrategy sortStrategy() {

Review comment:
       This is a little strange to me. It feels more like a 
`createSortStrategy()`, but I think it's fine since it isn't exposed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to