RussellSpitzer commented on a change in pull request #3097:
URL: https://github.com/apache/iceberg/pull/3097#discussion_r706166892
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -247,26 +247,25 @@ protected String defaultWarehouseLocation(TableIdentifier
tableIdentifier) {
@Override
public boolean dropTable(TableIdentifier identifier, boolean purge) {
if (!isValidIdentifier(identifier)) {
- throw new NoSuchTableException("Invalid identifier: %s", identifier);
Review comment:
This is actually a dead code block for this class. If you check
isValidIdentifier it is ```return true```. I think we should just leave this
bit as is for now and maybe clean it up in a future pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
