rdblue commented on a change in pull request #2933:
URL: https://github.com/apache/iceberg/pull/2933#discussion_r706486466
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ArrowReader.java
##########
@@ -206,15 +238,28 @@ public void close() throws IOException {
boolean caseSensitive,
int batchSize,
boolean reuseContainers) {
- this.fileTasks = StreamSupport.stream(tasks.spliterator(), false)
+ List<FileScanTask> fileTasks = StreamSupport.stream(tasks.spliterator(),
false)
.map(CombinedScanTask::files)
.flatMap(Collection::stream)
.collect(Collectors.toList());
this.fileItr = fileTasks.iterator();
+ if (fileTasks.stream().anyMatch(TableScanUtil::hasDeletes)) {
+ throw new UnsupportedOperationException("Cannot read files that
require applying delete files");
+ }
+ if (expectedSchema.columns().isEmpty()) {
Review comment:
Style nit: Iceberg adds an empty newline after control flow statements
like `if`/`else`/`for`/`while`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
