WinkerDu commented on a change in pull request #3073:
URL: https://github.com/apache/iceberg/pull/3073#discussion_r706546034
##########
File path: core/src/main/java/org/apache/iceberg/actions/BinPackStrategy.java
##########
@@ -211,7 +220,13 @@ protected long writeMaxFileSize() {
}
private long sizeOfInputFiles(List<FileScanTask> group) {
- return group.stream().mapToLong(FileScanTask::length).sum();
+ return group.stream().mapToLong(this::sizeOfInputFile).sum();
+ }
+
+ private long sizeOfInputFile(FileScanTask file) {
Review comment:
I think the `file groups` here depends the rewrite job scale, it should
take into account how much delete files cost in each rewrite job, otherwise
there could be 'job-level' unbalanced issue.
@rdblue @RussellSpitzer what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
