RussellSpitzer commented on pull request #3043: URL: https://github.com/apache/iceberg/pull/3043#issuecomment-917675914
I don't think we need "enabled" but I'm fine with anything really. On Sun, Sep 12, 2021 at 11:44 AM Ryan Blue ***@***.***> wrote: > Allow isn't a good term because it implies failure if something is not > allowed, not skipping. Skip and omit are okay, but I think that we want the > default to be false so that adding the setting is positive: keep empty > commits vs skip empty commits. That helps the default seem less surprising. > > So what I'm leaning toward is commit.keep-empty.enabled. Does that sound > alright to everyone? > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/3043#issuecomment-917669762>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YI7MRQ4LQ3MN67IU5LUBTKHVANCNFSM5C6NFAYQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
