aokolnychyi commented on a change in pull request #2921:
URL: https://github.com/apache/iceberg/pull/2921#discussion_r707691201
##########
File path:
spark3/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -90,7 +96,14 @@ public StructType outputType() {
if (retainLastNum != null) {
action.retainLast(retainLastNum);
}
-
+ if (numThreads != null && numThreads > 0) {
Review comment:
+1 on adding validation.
I would consider keeping the null value, though, to allow the underlying
action to default it to whatever it wants. I think we do that for other params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
