stevenzwu opened a new issue #3112:
URL: https://github.com/apache/iceberg/issues/3112


   @kbendick and @nastra found out that this test caused build to stuck in the 
infinite loop of waiting for required checkpoint to complete
   ```
         synchronized (ctx.getCheckpointLock()) {
           while (running && numCheckpointsComplete.get() < checkpointToAwait) {
             ctx.getCheckpointLock().wait(1);
           }
         }
   ```
   
   The problem is that `TestFlinkIcebergSink.testTwoSinksInDisjointedDAG` has 
two disjointed pipelines. The extra `+2` checkpoints waiting broke in this 
situation where part of the DAG has finished.
   ```
           // Let's say checkpointToAwait = numCheckpointsComplete.get() + 
delta, in fact the value of delta should not
           // affect the final table records because we only need to make sure 
that there will be exactly
           // elementsPerCheckpoint.size() checkpoints to emit each records 
buffer from the original elementsPerCheckpoint.
           // Even if the checkpoints that emitted results are not continuous, 
the correctness of the data should not be
           // affected in the end. Setting the delta to be 2 is introducing the 
variable that produce un-continuous
           // checkpoints that emit the records buffer from 
elementsPerCheckpoints.
           checkpointToAwait = numCheckpointsComplete.get() + 2;
   ```
   
   While FLIP-147 can make this test work again,  we can add a boolean flag to 
`BoundedTestSource` that can disable the `+2` behavior. what do you think? 
@kbendick @openinx 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to