openinx commented on a change in pull request #3085: URL: https://github.com/apache/iceberg/pull/3085#discussion_r708194612
########## File path: site/docs/flink-connector.md ########## @@ -15,21 +15,21 @@ - limitations under the License. --> -Apache Iceberg support creating flink table directly without creating explicit flink catalog in flink SQL in [#2666](https://github.com/apache/iceberg/pull/2666). That means we can just create an iceberg table with specifying 'connector'='iceberg' table option in flink SQL which is similar to the flink official [document](https://nightlies.apache.org/flink/flink-docs-release-1.13/docs/connectors/table/overview/). +Apache Iceberg supports creating flink table directly without creating the explicit flink catalog in flink SQL in [#2666](https://github.com/apache/iceberg/pull/2666). That means we can just create an iceberg table by specifying `'connector'='iceberg'` table option in flink SQL which is similar to usage in the flink official [document](https://nightlies.apache.org/flink/flink-docs-release-1.13/docs/connectors/table/overview/). In flink, the SQL `CREATE TABLE test (..) WITH ('connector'='iceberg', ...)` will create an flink table in current flink catalog (use [GenericInMemoryCatalog](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/dev/table/catalogs/#genericinmemorycatalog) by default), -which is just map to the underlying iceberg table instead of maintaining iceberg table. +which is just mapping to the underlying iceberg table instead of maintaining iceberg table directly in current flink catalog. -To create flink table backend iceberg table in flink SQL by using syntax `CREATE TABLE test (..) WITH ('connector'='iceberg', ...)`, flink iceberg connector provides the following table properties: +To create the table in flink SQL by using SQL syntax `CREATE TABLE test (..) WITH ('connector'='iceberg', ...)`, flink iceberg connector provides the following table properties: * `connector`: Use the constant `iceberg`. -* `catalog-name`: User-specified catalog name. -* `catalog-type`: The optional values are: - * `hive`: The hive metastore catalog. Use `hive` by default if we don't specify any value for `catalog-type`. +* `catalog-name`: User-specified catalog name. It's required because the connector don't have any default value. +* `catalog-type`: Default to use `hive` if don't specify any value. The optional values are: + * `hive`: The hive metastore catalog. * `hadoop`: The hadoop catalog. - * `custom`: All database and tables are maintained in the customized catalog, see [custom catalog](https://iceberg.apache.org/custom-catalog/) for more details. + * `custom`: The customized catalog, see [custom catalog](./custom-catalog.md) for more details. * `catalog-database`: The iceberg database name in the backend catalog, use the current flink database name by default. -* `catalog-table`: The iceberg table name in the backend catalog. +* `catalog-table`: The iceberg table name in the backend catalog. Default to use the `<table-name>` in the flink DDL `CREATE TABLE <table-name> (..) WITH ('connector'='iceberg', ...)`. Review comment: Okay, I've made this more clear in the updated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
