aokolnychyi commented on a change in pull request #3133:
URL: https://github.com/apache/iceberg/pull/3133#discussion_r710429396



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -388,6 +392,40 @@ public boolean isVectorizationEnabled(FileFormat 
fileFormat) {
     }
   }
 
+  private int batchSize(boolean isParquetOnly, boolean isOrcOnly) {
+    if (isParquetOnly) {
+      return batchSize(FileFormat.PARQUET);
+    } else if (isOrcOnly) {
+      return batchSize(FileFormat.ORC);
+    } else {
+      return 0;
+    }
+  }
+
+  private int batchSize(FileFormat fileFormat) {

Review comment:
       This PR is a temporary solution until we consume #3132 that will put 
this logic in one place for Spark 2 and 3.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to