rdblue commented on a change in pull request #3056:
URL: https://github.com/apache/iceberg/pull/3056#discussion_r711278788
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/BaseCatalog.java
##########
@@ -45,4 +45,6 @@ public Procedure loadProcedure(Identifier ident) throws
NoSuchProcedureException
throw new NoSuchProcedureException(ident);
}
+
+ protected abstract boolean dropTableWithPurge(Identifier ident, boolean
purge);
Review comment:
This doesn't need to be an abstract method on this class. Both
implementations of `BaseCatalog` implement `dropTableWithPurge` and it should
just be private in both of those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
