rdblue commented on a change in pull request #2945:
URL: https://github.com/apache/iceberg/pull/2945#discussion_r711313203
##########
File path:
core/src/main/java/org/apache/iceberg/deletes/PositionDeleteWriter.java
##########
@@ -55,15 +56,27 @@ public PositionDeleteWriter(FileAppender<StructLike>
appender, FileFormat format
this.pathSet = CharSequenceSet.empty();
}
+ @Override
+ public void write(PositionDelete<T> positionDelete) throws IOException {
+ pathSet.add(positionDelete.path());
+ appender.add(positionDelete);
Review comment:
This class makes an assumption similar to the `ClusteredFileWriter`
classes. Should we name it `OrderedPositionDeleteWriter` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
