rdblue commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r711776309



##########
File path: 
spark3/src/test/java/org/apache/iceberg/spark/source/TestPathIdentifier.java
##########
@@ -59,7 +59,7 @@
   @Before
   public void before() throws IOException {
     tableLocation = temp.newFolder();
-    identifier = new PathIdentifier(tableLocation.getAbsolutePath());
+    identifier = new PathIdentifier(tableLocation.getAbsolutePath(), null, 
null);

Review comment:
       Rather than changing this file, can you add a constructor to fill these 
in as defaults?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to