rdblue commented on a change in pull request #2953:
URL: https://github.com/apache/iceberg/pull/2953#discussion_r711792321
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -125,20 +125,24 @@ public static Schema select(Schema schema, Set<Integer>
fieldIds) {
return ImmutableSet.copyOf(getIdsInternal(type));
}
+ private static Set<Integer> getIdsInternal(Type type, boolean
includeStructIds) {
+ return visit(type, new GetProjectedIds(includeStructIds));
+ }
+
private static Set<Integer> getIdsInternal(Type type) {
- return visit(type, new GetProjectedIds());
+ return getIdsInternal(type, true);
Review comment:
Is it a lot of changes to remove this method? I wouldn't expect it since
this is `private`. I'd probably prefer removing it, but up to you if it touches
a bunch of unrelated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
